Skip to content

Add the containerd logging retrieval #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Add the containerd logging retrieval #5846

merged 1 commit into from
Aug 28, 2025

Conversation

@zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Aug 28, 2025

We are planning to make contianerD to output logs to the specified dir in the windows cluster, adding the log retrieval so that we can upload the containerd logs to the test grid portal

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.93%. Comparing base (766d93b) to head (ee24c7a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5846      +/-   ##
==========================================
- Coverage   46.94%   46.93%   -0.01%     
==========================================
  Files         279      279              
  Lines       29687    29687              
==========================================
- Hits        13936    13934       -2     
- Misses      14938    14940       +2     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marosset
Copy link
Contributor

marosset commented Aug 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 28, 2025

LGTM label has been added.

Git tree hash: 7570568405e7ec92d6df11068e69a41d03e67ad8

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 28, 2025

/hold

It looks like the latest e2e run has the new files but they're empty. Is that expected?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2025
@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 28, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 28, 2025
@marosset
Copy link
Contributor

marosset commented Aug 28, 2025 •
edited
Loading

/hold

It looks like the latest e2e run has the new files but they're empty. Is that expected?

I believe so.
We'll need https://github.com/kubernetes-sigs/windows-testing/pull/512/files to merge for the files to get populated for test ran from the windows-testing repo.
We could make the same changes in this repo too

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 28, 2025

SGTM, thanks!

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3762a31 into kubernetes-sigs:main Aug 28, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 28, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Aug 28, 2025
@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 28, 2025

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

1 more reviewer

@msft-linliu msft-linliu msft-linliu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

5 participants

@zylxjtu @marosset @k8s-ci-robot @nojnhuh @msft-linliu